Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating node #225

Merged
merged 4 commits into from
Oct 7, 2022
Merged

Updating node #225

merged 4 commits into from
Oct 7, 2022

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 6, 2022 •
edited
Loading

Updating node

@jpuri jpuri requested a review from a team as a code owner October 6, 2022 11:58
Mrtenz
Mrtenz previously requested changes Oct 6, 2022
View reviewed changes
Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update .nvmrc, README.md and any workflows using Node 12 as well.

@jpuri jpuri requested a review from Mrtenz October 6, 2022 12:02
@jpuri
Copy link
Contributor Author

jpuri commented Oct 6, 2022

This check should probably be removed now Build, Lint, and Test / Build, Lint, and Test (12.x) (pull_request)

@jpuri jpuri mentioned this pull request Oct 6, 2022
Merged
@Gudahtt
Copy link
Member

Gudahtt commented Oct 6, 2022

@jpuri you can adjust that here: https://github.com/MetaMask/providers/blob/main/.github/workflows/build-test-lint.yml#L14

@jpuri
Copy link
Contributor Author

jpuri commented Oct 6, 2022

@Gudahtt , @Mrtenz : PR is updated.

Gudahtt
Gudahtt approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt dismissed Mrtenz’s stale review October 6, 2022 21:15

Requested change has been made

mcmire
mcmire approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, LGTM too.

@jpuri jpuri merged commit d223e8f into main Oct 7, 2022
@jpuri jpuri deleted the update_node branch October 7, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@mcmire mcmire mcmire approved these changes

@Mrtenz Mrtenz Awaiting requested review from Mrtenz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpuri @Gudahtt @mcmire @Mrtenz